git() in src-tauri/src/git.rs starts git with the CREATE_NO_WINDOW flag on Windows. Windows no longer opens a console window for each git command, so nothing flashes and nothing takes the focus away from gites. The flag is only set in Windows builds.
load() in src/App.vue does nothing while a reload is still running. The window gets focus often, and overlapping reloads only run git more times.
Checked
The Windows part of git() compiles for x86_64-pc-windows-msvc. A deliberate type error in that part was reported, which proves the compiler checked it.
Unit tests for the window code and the Rust code pass, and the type checks pass.
Not checked
Nobody has run this build on Windows yet. The flashing and the slowness should stop. The 0xc0000142 crash should stop too if it came from the console windows, but that is not proven. Please try it on Windows before merging.
Fixes #2.
## Changes
- `git()` in `src-tauri/src/git.rs` starts git with the `CREATE_NO_WINDOW` flag on Windows. Windows no longer opens a console window for each git command, so nothing flashes and nothing takes the focus away from gites. The flag is only set in Windows builds.
- `load()` in `src/App.vue` does nothing while a reload is still running. The window gets focus often, and overlapping reloads only run git more times.
## Checked
- The Windows part of `git()` compiles for `x86_64-pc-windows-msvc`. A deliberate type error in that part was reported, which proves the compiler checked it.
- Unit tests for the window code and the Rust code pass, and the type checks pass.
## Not checked
Nobody has run this build on Windows yet. The flashing and the slowness should stop. The 0xc0000142 crash should stop too if it came from the console windows, but that is not proven. Please try it on Windows before merging.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #2.
Changes
git()insrc-tauri/src/git.rsstarts git with theCREATE_NO_WINDOWflag on Windows. Windows no longer opens a console window for each git command, so nothing flashes and nothing takes the focus away from gites. The flag is only set in Windows builds.load()insrc/App.vuedoes nothing while a reload is still running. The window gets focus often, and overlapping reloads only run git more times.Checked
git()compiles forx86_64-pc-windows-msvc. A deliberate type error in that part was reported, which proves the compiler checked it.Not checked
Nobody has run this build on Windows yet. The flashing and the slowness should stop. The 0xc0000142 crash should stop too if it came from the console windows, but that is not proven. Please try it on Windows before merging.